-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove export handling from getExportPaths for wildcard matching #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jiachi Liu <[email protected]>
- temporary?
Co-authored-by: Jiachi Liu <[email protected]>
huozhi
changed the title
refac(wildcard): remove export handling from getExportPaths
refactor: remove export handling from getExportPaths for wildcard matching
Aug 20, 2023
huozhi
reviewed
Aug 20, 2023
huozhi
reviewed
Aug 20, 2023
huozhi
reviewed
Aug 20, 2023
@huozhi Could you help me out on simplifying this code? ObjectiveReturn resolved exports by replacing resolved wildcard exports to the current Codeconst resolvedExports = Object.assign(
{},
exports,
...resolvedWildcardExports, // typeof ExportCondition[]
exports,
)
delete resolvedExports['./*']
return resolvedExports |
Closed
huozhi
reviewed
Sep 4, 2023
huozhi
reviewed
Sep 4, 2023
Co-authored-by: Jiachi Liu <[email protected]>
Co-authored-by: Jiachi Liu <[email protected]>
devjiwonchoi
commented
Sep 4, 2023
huozhi
reviewed
Sep 4, 2023
huozhi
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Explanation
The
Wildcard Exports
feature allows the user to setexports['./*']
, and bunchee maps the wildcard with theExportable Entries
.Requirements
The
Exportable Entries
a.k.a.exportables
need to be inside the rootsrc
directory.Exportable Entries
js | cjs | mjs | jsx | ts | tsx | cts | mts
- excludingindex
(entry for['.']
).index
file(s) with allowed extension.Usage
Folder Structure:
Will be treated as:
Resolves: #243